Dear xiangfu liu,
Hi Marek
On Sat, Oct 13, 2012 at 8:23 PM, Marek Vasut marex@denx.de wrote:
Dear xiangfu liu,
Hi Marek
This file was wrote by Ingenic people. I don't have time to convert it to C(I am not very good in mips assembler). the .S file implement basic USB stack.
We already do have an USB stack.
This usbboot.S implement a very base usb-client protocol and it implement a jz4740 hardware feature.
We have that too -- see drivers/usb/gadget/
(jz4740 have a hard-code rom inside cpu. that have the same feature, they named it 'boot from usb'). so this usbboot.S is for implement the same feature in a software way.
Won't DFU work then?
and I think this usbboot.S can move to 'arch/mips/cpu/xburst/spl/jz4740_usbboot.s' in future. and I don't think it will impact with other usb code in u-boot.
That's even worse, the USB code shall be in drivers/usb/
this C code (
http://projects.qi-hardware.com/index.php/p/xburst-tools/source/tree/mast er
/xbboot) implement the host app. the host app source code even clear then the original Ingenic document. so feel free to send patch.
Sorry, but it is my duty as a USB custodian to NAK patches which try to circumvent the constant effort to keep the code clean. Obviously, implementing yet another USB stack is violation of this.
Yes. I understand your duty. and keep a project code clean is not easy. thanks for feedback. (I never look into u-boot usb code. don't have much experience on u-boot usb structure. :)
All the best Xiangfu
Best regards, Marek Vasut