On Tue, 07 Aug 2007 12:06:29 -0400 Jerry Van Baren vanbaren@cideas.com wrote:
err = fdt_setprop(fdt, nodeoffset, "ethspeed", &bd->bi_ethspeed, 4); if (err < 0)
printf("WARNING fdt_bd_t: ""could not set ethspeed (%s).\n",
printf("WARNING: ""could not set ethspeed %s.\n",
some of these changes fit in 80 cols. It'd be nice to see the 3-liner printfs reduced to 2-liners.
btw, in case you wanted someone to actually test, or check consistency even, they can't because git-am bails with a "fatal: corrupt patch at line 14". Meanwhile, checkpatch.pl suggests you have bad mailer settings:
--- [kim@localhost u-boot]$ ../linux-2.6/scripts/checkpatch.pl --no-tree 44 ERROR: patch seems to be corrupt (line wrapped?) #71: FILE: common/fdt_support.c:53: initrd_end, int force)
ERROR: patch seems to be corrupt (line wrapped?) #81: FILE: common/fdt_support.c:65: initrd_end, int force)
ERROR: patch seems to be corrupt (line wrapped?) #96: FILE: common/fdt_support.c:87: initrd_end, int force)
ERROR: patch seems to be corrupt (line wrapped?) #106: FILE: common/fdt_support.c:113: initrd_end, int force)
ERROR: patch seems to be corrupt (line wrapped?) #118: FILE: common/fdt_support.c:128: initrd_end, int force)
ERROR: patch seems to be corrupt (line wrapped?) #130: FILE: common/fdt_support.c:137: ulong initrd_end, int force)
Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. ---
Kim