On 09.05.20 19:59, Denis 'GNUtoo' Carikli wrote:
On Sun, 1 Mar 2020 14:59:23 +0100 Soeren Moch smoch@web.de wrote:
To ease the review process it is good style to add a patch revision history below the sign-off after a "---" separator. This would look like --- changes in v4: - bla
I usually use that to indicate changes that do not correspond to the changes requested by the reviewers, or where the fix is slightly different from the one suggested during the review.
This usually is better addressed in a discussion before sending a new version of a patch series. Just ignoring review comments often leads to rejection of the new patch, this is waste of time for everybody, and unnecessarily delays patch merging. Of course reviewers not always have the best idea how to solve a problem. But discussing pros and cons in a direct answer to the review is much faster and easier as always sending a new version of the patches.
If the fix sticks to precisely what was suggested, does it still helps to include such changes in the ChangeLog too?
Yes , this helps for sure. Even if there is no change at all in some patches of a series, it helps if there is a --- changes in v4: - none
Soeren