
On Tue, Dec 13, 2022 at 01:59:01PM +0000, Alexey Romanov wrote:
Hello!
On Mon, Dec 12, 2022 at 11:08:34AM -0500, Tom Rini wrote:
On Fri, Dec 09, 2022 at 03:52:04PM +0300, Alexey Romanov wrote:
Using this command user can print efuse memory:
$ sm efusedump 0 10 00000000: ff 00 31 00 00 ff 66 00 00 00 ..1...f...
Signed-off-by: Alexey Romanov avromanov@sberdevices.ru
arch/arm/mach-meson/sm.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-)
This needs to be moved done under cmd/ somewhere, perhaps cmd/meson/
-- Tom
Do you mean it must be moved by a different patchset? From my point of view, your comment is totally right, because arch dependent commands are located at cmd/ARCH path. But I'm afraid my patchset is just about new helper command.
Anyway, I can send a new different patchset with refactoring suggested by you. But, please, comment out some words about new efuse command if possible.
I think your changes are fine, I'd like to see this as a 2 part patch where part 1 is just moving the code and 2 is adding your changes.