Do you have a link to the announcement of the board ? Is it publically available ? Tom
VIVEK DALAL wrote:
Hi Tom
On Jul 02, 2009 00:18 (GMT+09:00) Tom.Rix@windriver.com wrote :
A large part of your changes are reorganizing omap24xx support. Have you looked at how it is already done in omapzoom ? git://git.omapzoom.org/repo/uboot.git I believe omapzoom does it better.
--- Thats one way you can do it. Other way is what I did. Rather then adding seperate files(in include/asm-arm/arch-omap24xx/ folder) for omap2430, what have been done in omapzoom/repo/uboot.git i.e omap2420., omap2430.h, clock.h, clock242x.h, clock243x.h etc. Its better to use #define and put the processor specific code in those macros and make the file names generic. Imagine the scenerio, if there would be 5 processors based on arm1136.
These changes are likely going to conflict with my recent i2c patch http://lists.denx.de/pipermail/u-boot/2009-June/055071.html
---I think you are only modifying i2c.h file in include/asm-arm/arch-omap24xx/ folder. So thats the only conflicting file between your patch and my patch. In that file I have changed only two lines i.e -#define I2C_BASE 0x48070000 -#define I2C_BASE2 0x48072000 /* nothing hooked up on h4 */ +/* I2C base */ +#define I2C_BASE (OMAP24XX_L4_IO_BASE + 0x70000) +#define I2C_BASE2 (OMAP24XX_L4_IO_BASE + 0x72000) This minimal change will not be heavy when re-basing.
Regards Vivek Dalal