Dear Wolfgang,
On 23 April 2012 18:22, Wolfgang Denk wrote:
Dear Donghwa Lee,
In message 4F94B49E.5020802@samsung.com you wrote:
This patches support drawing 32bpp bitmap TIZEN logo in exynos fb. asm/arch/trats_logo.h data is compressed by zip and decomressed at the exynos fb driver.
And vl_bpix of vidinfo_t is changed proper value for u-boot.
Signed-off-by: Donghwa Lee dh09.lee@samsung.com Signed-off-by: Kyungmin park kyungmin.park@samsung.com
arch/arm/include/asm/arch-exynos/trats_logo.h | 5070 +++++++++++++++++++++++++ board/samsung/trats/trats.c | 2 +- drivers/video/exynos_fb.c | 40 +- drivers/video/exynos_fimd.c | 6 +- include/configs/trats.h | 4 +- 5 files changed, 5116 insertions(+), 6 deletions(-) create mode 100644 arch/arm/include/asm/arch-exynos/trats_logo.h
diff --git a/arch/arm/include/asm/arch-exynos/trats_logo.h b/arch/arm/include/asm/arch-exynos/trats_logo.h new file mode 100644 index 0000000..a595abd --- /dev/null +++ b/arch/arm/include/asm/arch-exynos/trats_logo.h
This is not a good location for the logo data. Either this is vendor specific, in which place it should go to the vendor directory, or it's board specific, in which case it should go into the board directory.
In no case I want to have this in arch/arm/include/
thanks.
Best regards,
Wolfgang Denk
Thank you for your comment. This logo data is TIZEN logo for TRATS board. Current TIZEN reference board is TRATS based on EXYNOS SoC. But, I don'know exactly any others boards that loaded TIZEN based on others SoC will be appeared in the future.
So, I think this logo data is not board(TRATS) and vendor(EXYNOS) specific. So, I want to move this data in include/
How do you think about that? Plese tell me your opinions.
Thank you, Donghwa Lee