20 Nov
2018
20 Nov
'18
11:04 p.m.
On 20.11.18 19:32, Andy Shevchenko wrote:
On Thu, Nov 15, 2018 at 11:45:32AM -0800, Simon Glass wrote:
On 15 November 2018 at 09:58, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
+/* REVISIT: ACPI GAS specification implied */ +struct serial_device_info {
unsigned int baudrate;u8 addr_space; /* 0 - MMIO, 1 - IO */Please make this an enum
OK.
u8 reg_width;u8 reg_offset;u8 reg_shift;u64 addr;ulong
This, unfortunately, will not work. ACPI takes the address as 32-bit halves, and shift to 32 on 32-bit platform is UB.
I guess what Simon wanted to get to is more something like "phys_addr_t" which actually tells you what the variable is supposed to transfer.
Keep in mind that this is only for interim data. You can put this into a u64 before putting it into the ACPI table inside your ACPI specific code just fine.
Alex