Re: [U-Boot] [PATCH] i2c: Fix chip address.0

Hello Joakim,

Joakim Tjernlund write:

According to the i2c command alen 0 should be allowed but this is not allowed in the implementation, fix. Also cleanup all cmd_usage cases while at it. It is cleaner to return cmd_usage(cmdtp); instead of { cmd_usage(cmdtp); return 1; }

Signed-off-by: Joakim Tjernlund Joakim.Tjernlund@transmode.se

common/cmd_i2c.c | 107 +++++++++++++++++++++--------------------------------- 1 files changed, 41 insertions(+), 66 deletions(-)

Hmm... did you use actual top of tree?

Your patch didn;t apply, also I think the issues your patch try to fix, should be fixed in TOT:

- actual TOT common/cmd_i2c.c uses "return cmd_usage(cmdtp);" - alen of 0 should also be possible, fixed in commit 7a92e53cd0d8164d518216bebd52679603d6ffe9 from Reinhard Meyer.

Please try actual TOT

bye, Heiko