On Dec 4, 2017, at 21:02, Peng Fan van.freenix@gmail.com wrote:
On Tue, Nov 28, 2017 at 05:14:58PM +0000, York Sun wrote:
On 11/27/2017 07:20 PM, Peng Fan wrote: For external data, FIT has a optional property "data-position" which can set the external data to a fixed offset to FIT beginning. Add the support for this property in SPL FIT.
Signed-off-by: Ye Li ye.li@nxp.com Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Simon Glass sjg@chromium.org Cc: Pantelis Antoniou pantelis.antoniou@konsulko.com Cc: "Andrew F. Davis" afd@ti.com Cc: Igor Grinberg grinberg@compulab.co.il Cc: "tomas.melin@vaisala.com" tomas.melin@vaisala.com Cc: Kever Yang kever.yang@rock-chips.com Cc: Andre Przywara andre.przywara@arm.com Cc: York Sun york.sun@nxp.com Cc: Lokesh Vutla lokeshvutla@ti.com Cc: "Cooper Jr., Franklin" fcooper@ti.com Cc: George McCollister george.mccollister@gmail.com Cc: Tuomas Tynkkynen tuomas.tynkkynen@iki.fi Cc: Jean-Jacques Hiblot jjhiblot@ti.com Cc: Rick Altherr raltherr@google.com Cc: Tom Rini trini@konsulko.com
common/image-fit.c | 25 +++++++++++++++++++++++++ common/spl/spl_fit.c | 11 +++++++++-- include/image.h | 3 +++ 3 files changed, 37 insertions(+), 2 deletions(-)
Looks good. Would it be appropriate to update doc/uImage.FIT/source_file_format.txt to include this property?
All,
Is the following explaination ok?
diff --git a/doc/uImage.FIT/source_file_format.txt b/doc/uImage.FIT/source_file_format.txt index 6f727a1e8a..0db23db6c7 100644 --- a/doc/uImage.FIT/source_file_format.txt +++ b/doc/uImage.FIT/source_file_format.txt @@ -288,7 +288,8 @@ In this case the 'data' property is omitted. Instead you can use:
The 'data-offset' property can be substituted with 'data-position', which defines an absolute position or address as the offset. This is helpful when -booting U-Boot proper before performing relocation. +booting U-Boot proper before performing relocation. Pass `-p [offset]` to +mkimage to enable `data-position`.
If it is ok, I'll add it into V2.
It's something. I am OK.
York