Re: [PATCH 1/2] pci: pci_mvebu: Remove unused SELECT and lane_mask

On 2/18/22 12:25, Pali Rohár wrote:

Macro SELECT() is unused and struct mvebu_pcie field lane_mask is unused too. Remove them.

Signed-off-by: Pali Rohár pali@kernel.org

Reviewed-by: Stefan Roese sr@denx.de

Thanks, Stefan

---

drivers/pci/pci_mvebu.c | 3 --- 1 file changed, 3 deletions(-)

diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c index 5a0a59a8b9ec..16fe54fd366f 100644 --- a/drivers/pci/pci_mvebu.c +++ b/drivers/pci/pci_mvebu.c @@ -30,8 +30,6 @@ #include <linux/sizes.h>

/* PCIe unit register offsets */ -#define SELECT(x, n) ((x >> n) & 1UL)

• #define PCIE_DEV_ID_OFF 0x0000 #define PCIE_CMD_OFF 0x0004 #define PCIE_DEV_REV_OFF 0x0008

@@ -77,7 +75,6 @@ struct mvebu_pcie { u32 lane; bool is_x4; int devfn;

• u32 lane_mask; int sec_busno; char name[16]; unsigned int mem_target;

Viele Grüße, Stefan Roese