Re: [U-Boot] [PATCH v4] Marvell MV88F6281GTW_GE Board support

+# (C) Copyright 2009

• • This program is distributed in the hope that it will be useful,
• • but WITHOUT ANY WARRANTY; without even the implied warranty of
• • MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
• • GNU General Public License for more details.
• • You should have received a copy of the GNU General Public License
• • along with this program; if not, write to the Free Software
• • Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
• • MA 02110-1301 USA
• */

+#include <common.h> +#include <../drivers/net/phy/mv88e61xx.h>

Ben I not sure it's clean any better idea?

+#include <netdev.h> +#include "mv88f6281gtw_ge.h"

+DECLARE_GLOBAL_DATA_PTR;

+int board_init(void) +{

please add comment

• kw_config_gpio(MV88F6281GTW_GE_OE_VAL_LOW,

•        MV88F6281GTW_GE_OE_VAL_HIGH,
  

•        MV88F6281GTW_GE_OE_LOW, MV88F6281GTW_GE_OE_HIGH);
  

• /* Multi-Purpose Pins Functionality configuration */
• kw_config_mpp(MV88F6281GTW_GE_MPP0_7,

•       MV88F6281GTW_GE_MPP8_15,
  

•       MV88F6281GTW_GE_MPP16_23,
  

•       MV88F6281GTW_GE_MPP24_31,
  

•       MV88F6281GTW_GE_MPP32_39,
  

•       MV88F6281GTW_GE_MPP40_47, MV88F6281GTW_GE_MPP48_55);
  

From

• /* serial config */
• gd->baudrate = CONFIG_BAUDRATE;

againt please remove

• /*

• * arch number of USED SOC
  

• */
  

• gd->bd->bi_arch_number = MACH_TYPE_MV88F6281GTW_GE;
• /* adress of boot parameters */
• gd->bd->bi_boot_params = kw_sdram_bar(0) + 0x100;
• return 0;

+}

+int dram_init(void) +{

• int i;
• for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {

• gd->bd->bi_dram[i].start = kw_sdram_bar(i);
  

• gd->bd->bi_dram[i].size = kw_sdram_bs(i);
  

• }
• return 0;

+}

index 0000000..9695f3f --- /dev/null +++ b/board/Marvell/mv88f6281gtw_ge/u-boot.lds

please move to cpu/arm/kirkwood/

@@ -0,0 +1,53 @@ +/*

• • (C) Copyright 2009
• • Marvell Semiconductor <www.marvell.com>
• • Prafulla Wadaskar prafulla@marvell.com
• • See file CREDITS for list of people who contributed to this
• • project.
• • This program is free software; you can redistribute it and/or
• • modify it under the terms of the GNU General Public License as
• • published by the Free Software Foundation; either version 2 of
• • the License, or (at your option) any later version.
• • This program is distributed in the hope that it will be useful,
• • but WITHOUT ANY WARRANTY; without even the implied warranty of
• • MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
• • GNU General Public License for more details.
• • You should have received a copy of the GNU General Public License
• • along with this program; if not, write to the Free Software
• • Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
• • MA 02110-1301 USA
• */

+OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") +OUTPUT_ARCH(arm) +ENTRY(_start) +SECTIONS +{

• . = _start;
• . = ALIGN(4);
• .text :
• {

•  cpu/arm926ejs/start.o	(.text)
  

•  *(.text)
  

• }
• .rodata : { *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata))) }
• . = ALIGN(4);
• .data : { *(.data) }
• . = ALIGN(4);
• .got : { *(.got) }
• • MA 02110-1301 USA
• */

+#ifndef _CONFIG_MV88F6281GTW_GE_H +#define _CONFIG_MV88F6281GTW_GE_H

+/*

• • Version number information
• */

+#define CONFIG_IDENT_STRING "\nMarvell-MV88F6281GTW_GE-A0"

+/*

• • High Level Configuration Options (easy to change)
• */

+#define CONFIG_MARVELL 1 +#define CONFIG_ARM926EJS 1 /* Basic Architecture */ +#define CONFIG_FEROCEON_88FR131 1 /* CPU Core subversion */ +#define CONFIG_KIRKWOOD 1 /* SOC Family Name */ +#define CONFIG_KW88F6281 1 /* SOC Name */

please define the CONFIG_MACH

+#ifdef CONFIG_KIRKWOOD

as I guess it will be always KIRKWOOD please remove

+#define CONFIG_MD5 /* get_random_hex on krikwood needs MD5 support */ +#define CONFIG_ARCH_LOWLEVEL_INIT /* enable arch_lowlevel_init */ +#define CONFIG_SKIP_LOWLEVEL_INIT /* disable board lowlevel_init */ +#define CONFIG_KIRKWOOD_EGIGA_INIT /* Enable GbePort0/1 for kernel */ +#define CONFIG_KIRKWOOD_PCIE_INIT /* Enable PCIE Port0 for kernel */ +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8 /* Set RGMII Pad voltage to 1.8V */ +#endif

otherwise fine

Best Regards, J.