Hi Joe,
<snip>
This is generic gpio cleanup but I don't think this is the same thing. I think you should get some warnings for fdtdec compilation aroundmissing gpio_request declaration or you include gpio.h in any other header file which is in fdtdec.c/h.
Sorry I don't really understand that. For me fdtdec.c has #include <asm-generic/gpio.h> and that is enough to get gpio_request(). Can you please advise what warning you see and for what board?
Microblaze: lib/libgeneric.o: In function `fdtdec_setup_gpio': /mnt/projects/u-boot/lib/fdtdec.c:477: undefined reference to `gpio_request'
The same error will be for nios2, openrisc and blackfin because they define gpio_request as static inline function in arch/<arch>/include/asm/gpio.h
Because I think there should be asm/gpio.h included which can include asm-generic/gpio.h (this is arm case).
When you send an updated patch you need to add V2 or whatever to the subject and you need to include a change log here.
I think you meant to reject this, not the other one here: http://patchwork.ozlabs.org/patch/170457
I have sent this patch http://lists.denx.de/pipermail/u-boot/2012-July/128257.html
which has broken subject that's why I have sent this message (it took me 2-3 mins) http://lists.denx.de/pipermail/u-boot/2012-July/128259.html
And also send correct patch with proper subject and changelog http://lists.denx.de/pipermail/u-boot/2012-July/128258.html http://patchwork.ozlabs.org/patch/170458/
Can you please clarify what's wrong?
Thanks, Michal