On Fri, 2013-11-29 at 18:57 +0900, Jaehoon Chung wrote:
I think good that just removed the "#include <asm/arch/dwmmc.h>". Instead, Exnyos specific code can move into dw-mmc-exynos.c with callback function. (I didn't know whcih Soc is used with MPSCTRL register.)
Because of this you selected this offset "0x9c" and experience no problems. But at some point you may get HW configured to use 64-bit addressing and you'll need to use another offset for Exynos-specific things. I understand that as SW engineer you have not much things to do here but would be good if you communicate this to HW engineers.
If other soc is used 0x9c offset as other register? 0x9c is used the CLKSEL at exynos. we need to consider other soc. Then it's good that exynos specific code will move into dw-mmc-exynos.c. isn't?
Ok, so please look at my re-spin I already sent (you were on CC-list). There I only mask problematic bits of code - so driver works again for me (I'm on other architecture BTW - not ARM).
But if you're willing to clean-up dwmmc code from Exynos-specific parts I'll be more than happy.
Well it doesn't stop us from application of my v2 that will be a temporary fix until clean-up.
-Alexey