Re: [PATCH] net: fsl-mc: fix logically dead code

On Wed, Jul 21, 2021 at 7:13 PM Cosmin-Florin Aluchenesei aluchenesei.cosmin-florin@nxp.com wrote:

The result of dpio_close() is actually taken into account.

Signed-off-by: Cosmin-Florin Aluchenesei aluchenesei.cosmin-florin@nxp.com

drivers/net/fsl-mc/mc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c index 972db4cf3a..914ec001ec 100644 --- a/drivers/net/fsl-mc/mc.c +++ b/drivers/net/fsl-mc/mc.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0+ /*

• Copyright 2014 Freescale Semiconductor, Inc.

• • Copyright 2017-2018, 2020 NXP

• • Copyright 2017-2018, 2020-2021 NXP
  */

#include <common.h> #include <command.h> @@ -1126,7 +1126,7 @@ static int dpio_exit(void) goto err; }

•   dpio_close(dflt_mc_io, MC_CMD_NO_FLAGS, dflt_dpio->dpio_handle);
  

•   err = dpio_close(dflt_mc_io, MC_CMD_NO_FLAGS, dflt_dpio->dpio_handle);
    if (err < 0) {
            printf("dpio_close() failed: %d\n", err);
            goto err;
  

-- 2.21.0

Reviewed-by: Ramon Fried rfried.dev@gmail.com