Hi Jesse,
On 2/14/21 4:55 AM, Jesse wrote:
From: Jesse Taube mr.bossman075@gmail.com
This timer driver is using GPT Timer (General Purpose Timer) available on almost all i.MX SoCs family. Since this driver is only meant to provide u-boot's timer and counter, and most of the i.MX* SoCs use a 24Mhz crystal, let's only deal with that specific source.
Jesse Taube (1): timer: imx-gpt: Add timer support for i.MX SoCs family
Since you're only sending a patch you should not include a cover letter. A cover letter should be included when your patches are more than one and they deal the same subject. So here you should only write a summary about it, like: ''' Subject: Add i.MX GPT timer support
This pachset adds i.MX GPT timer support and a modify to dts for imxrt1050-ekv that enables you to check its functionality. '''
drivers/timer/Kconfig | 7 ++ drivers/timer/Makefile | 1 + drivers/timer/imx-gpt-timer.c | 153 ++++++++++++++++++++++++++++++++++ 3 files changed, 161 insertions(+) create mode 100644 drivers/timer/imx-gpt-timer.c
V1->V2:
- Fixed indentation
- Fixed capitals
- Made timer work on only 24MHz clock
V2->V3:
- Fixed indentation
- Made implementation imatate the Linux kernel
- Fix wrong definition
V3->V4:
- Fixed indentation
- Made bit manipluation into its own function.
You should move ^^^ these changes as they are in patch 1/1.
Also take care that this patch is difficult to test alone since a defconfig(this is easy to enable) and a dts(this is really welcome) are missing, then you should also include at least the dts you were working at least. And that makes sense to have a patchset again then(because of 2 patches).