Re: [U-Boot] [PATCH] cs8900_initialize() cleanup [rev2]

Matthias,

Matthias Kaehlcke wrote:

cs8900_initialize(): remove unecessary calls to free() and fix memory leak

Signed-off-by: Matthias Kaehlcke matthias@kaehlcke.net

drivers/net/cs8900.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c index df36004..9424fb2 100644 --- a/drivers/net/cs8900.c +++ b/drivers/net/cs8900.c @@ -308,14 +308,13 @@ int cs8900_initialize(u8 dev_num, int base_addr)

dev = malloc(sizeof(*dev)); if (!dev) {

• free(dev);
  

  return 0; } memset(dev, 0, sizeof(*dev));

  priv = malloc(sizeof(*priv)); if (!priv) {

• free(priv);
  

• free(dev);
  

  return 0; } memset(priv, 0, sizeof(*priv));

Applied to net repo.

thanks, Ben