Re: [U-Boot] [PATCH] s5p: gpio: change gpio coding method for s5p gpio.

Hello Minkyu,

On 11/13/2013 01:01 PM, Przemyslaw Marczak wrote:

Old s5p gpio coding method returns bad bank address in few cases. Now it is working properly with every gpio part bank and pin and it is easy to extend.

Gpio coding mask: 0x000000ff - pin number 0x00ffff00 - bank offset 0xff000000 - part number

Tested on: Goni, Universal, Trats, Trats2.

Signed-off-by: Przemyslaw Marczak p.marczak@samsung.com CC: Minkyu Kang mk7.kang@samsung.com

Could you review this patch, please? Thanks