On Fri, 2007-04-20 at 15:40 -0500, Timur Tabi wrote:
Ulf Samuelsson wrote:
U-Boot has a number of network parameters like
CONFIG_HOSTNAME CONFIG_IPADDR CONFIG_GATEWAYIP CONFIG_NETMASK etc.
While these can be defined in an "include/configs/<board>.h", it would be nice to be able to define this in a separate file since they are really not board specific.
I agree that these don't belong in the board config file. In fact, I don't see why they should be board-specific at all. The U-Boot code in denx.de should have a config.h somewhere that specifies these, but we should probably not encourage board maintainers to have their own versions.
If these network parameters really need default values, it's probably better to initialize environment variables using CONFIG_EXTRA_ENV_SETTINGS, or something like that. I expect that almost every board that U-boot gets loaded on will have these values overwritten anyway to fit in whatever network it ends up in.
I think everyone so far is missing the point. My proposal is just to allow the u-boot developer to customize his/her build with environment variables generated outside the u-boot source tree.
It does not specify what the user is doing with this new flexibility.
Doing it this way is the "clean" way in my opinion, but If Wolfgang is going to complain, then I just have to do it anyway, but outside U-boot.
It is very easy to just copy an "include/config/<board>.h" file from outside u.-boot to "include/configs", adding the extra stuff I need at the end of that file.
Even if WD does not like fixed IP configuration there are other use for this
If you have a board with multiple memories, and you can store you environment in all of them, then you can use this function to define where the environment is instead of having multiple board files. It is really a pin to maintain multiple board files for this purpose alone.
regards, Ben
Best Regards Ulf Samuelsson ulf@atmel.com Atmel Nordic AB Mail: Box 2033, 174 02 Sundbyberg, Sweden Visit: Kavallerivägen 24, 174 58 Sundbyberg, Sweden Phone +46 (8) 441 54 22 Fax +46 (8) 441 54 29 GSM +46 (706) 22 44 57
Technical support when I am not available: AT89 C51 Applications Group: mailto:micro.hotline@nto.atmel.com AT90 AVR Applications Group: mailto:avr@atmel.com AT91 ARM Applications Group: mailto:at91support@atmel.com FPSLIC Application Group: mailto:fpslic@atmel.com Best AVR