On Monday 08 February 2021 23:15:33 Lukasz Majewski wrote:
Hi Pali,
Resended v2 patch series with fixed commit messagesThis patch series fix usbtty code (serial console via USB peripheral mode), fix underlying musb peripheral code, fix compilation of CONFIG_USB_DEVICE (used by usbtty), remove unused Nokia RX-51 code to decrease size of U-Boot binary and finally enable usbtty serial console for Nokia RX-51.
With this patch series debugging of Nokia RX-51 can be done also via USB serial console.
It fixes also stability of musb code and allows usage of file transfers via Kermit protocol on Nokia RX-51. Kermit file transfer via U-Boot loadb command is stable on Nokia N900 and gives about 52kB/s transfer rate.
On computer this serial console is accessible via /dev/ttyACM0 device.
I've integrated your patchset and now it turns out that the u-boot size is too big: https://dev.azure.com/lukma633/U-Boot/_build/results?buildId=24&view=res... https://dev.azure.com/lukma633/U-Boot/_build/results?buildId=24&view=log...
Ah :-( In November when I sent these patches, U-Boot binary was smaller.
The branch is https://github.com/lmajewski/u-boot-dfu/tree/testing
Have you experienced similar issues?
Yes, memory for U-Boot is limited. It is needed to decrease size of U-Boot binary and then it will work.
I will try to look at it later and find some dead code which can be commented or removed to decrease binary size...
If you have an idea what increased U-Boot side it could help.
Pali Rohár (16): serial: usbtty: Fix puts function serial: usbtty: Send urb data in correct order usb: musb: Fix compilation of gadget code usb: musb: Always clear the data toggle bit when configuring ep usb: musb: Fix configuring FIFO for endpoints usb: musb: Read value of PERI_RXCSR to 16bit variable usb: musb: Fix transmission of bigger buffers usb: musb: Fix receiving of bigger buffers usb: musb: Fix handling interrupts for EP0 and SET ADDRESS commmand usb: musb: Ensure that we set musb dynamic FIFO buffer for every endpoint usb: gadget: Use dbg_ep0() macro instead of serial_printf() arm: omap3: Compile lowlevel_init() function only when it is used arm: omap3: Compile s_init() function only when it is used Nokia RX-51: Remove function set_muxconf_regs() Nokia RX-51: Move content of rx51.h to rx51.c Nokia RX-51: Enable usbtty serial console by default
Makefile | 1 + arch/arm/mach-omap2/omap3/board.c | 3 + arch/arm/mach-omap2/omap3/lowlevel_init.S | 6 +- board/nokia/rx51/rx51.c | 28 +- board/nokia/rx51/rx51.h | 377 ---------------------- configs/nokia_rx51_defconfig | 7 +- doc/README.nokia_rx51 | 15 +- drivers/serial/usbtty.c | 16 +- drivers/usb/gadget/ep0.c | 16 +- drivers/usb/musb/musb_core.c | 12 +- drivers/usb/musb/musb_udc.c | 61 ++-- include/configs/nokia_rx51.h | 21 +- 12 files changed, 82 insertions(+), 481 deletions(-) delete mode 100644 board/nokia/rx51/rx51.h
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de