Re: [PATCH 2/7 v2] arm: clean up v7 and v8 linker scripts for bss_start/end

Hi Richard,

Thanks for taking a look

On Tue, 12 Mar 2024 at 17:51, Richard Henderson richard.henderson@linaro.org wrote:

On 3/12/24 04:08, Ilias Apalodimas wrote:

...

• .bss_start (NOLOAD) : {
  

•         . = ALIGN(8);
  

This alignment got lost.

...

•         KEEP(*(.__bss_start));
  

• } >.sdram
  

• .bss (NOLOAD) : {
  

• .bss : {
  

If it is required, the best replacement would be here on the output section definition.

As you mentioned in patch #7 we should preserve some alignments or fix the underlying assembly. But in any case, I'll preserve the .bss alignment here since it will be easy to bisect/read the commit logs & patches in the future

...

• . = ALIGN(8);
  

• .bss_start : {
  

•         KEEP(*(.__bss_start));
  

• }
  

• .bss : {
  

• .bss ALIGN(8): {
  

Like you did here.

Thanks! /Ilias

r~