On Saturday, December 18, 2010 18:17:43 Wolfgang Denk wrote:
Mike Frysinger wrote:
--- a/MAINTAINERS +++ b/MAINTAINERS @@ -1090,6 +1090,10 @@ Peter Meerwald devel@bct-electronic.com
bct-brettl2 BF536
+M.Hasewinkel (MHA) info@ssv-embedded.de
- dnp5370 BF537
Please keep list sorted.
the list is already not sorted, nor is it really feasible to do so. it's grouped by maintainer which may have multiply named boards.
--- /dev/null +++ b/board/dnp5370/config.mk +CONFIG_BFIN_CPU = bf537-0.3
Please mode to board config file, and drop the config.mk
as noted in the other patch, this is the only place for it.
+#define CONFIG_IPADDR 10.100.100.21 +#define CONFIG_NETMASK 255.255.0.0 +#define CONFIG_GATEWAYIP 10.100.100.1 +#define CONFIG_SERVERIP 10.100.100.12
NAK. We do not allow this.
i dont see why. these are *default* settings. there is nothing here that prevents people in their own board from overriding at runtime and saving the result into their environment. where as having default settings often makes new builds/tests a lot smoother. -mike