Dear Haiying Wang,
In message 1301583985.1991.4.camel@haiying-laptop you wrote:
What is "out-of-tree builds"? Why did LDFLAGS_FINAL patch break it? the
out-of-tree building means that you store all build results in some other directory, outside of the source tree. See item 3 under Notes at http://www.denx.de/wiki/U-Boot/Patches
Your patch broke it because it referenced $(nandobj) before defining it - aslong as the build directory and the source directory are the same, this makes no difference. But for out-of-tree builds...
$(nandobj) was defined in those Makefiles in that way before applying LDFLAGS_FINAL patch. Why could the out-of-tree builds passed before applying LDFLAG_FINAL patch?
Have a look at the changes introduced by your commit, and you will see. The problem is a bit buried in the changes of "=" into ":=" and "$(PLATFORM_LDFLAGS)" into "$(LDFLAGS) $(LDFLAGS_FINAL)" in lines like these:
-LDFLAGS = -Bstatic -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(PLATFORM_LDFLAGS) +LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ + $(LDFLAGS_FINAL)
[It is a bit strange to append to LDFLAGS line that.]
Best regards,
Wolfgang Denk