Dear Albert Aribaud,
In message 1277933418-682-1-git-send-email-albert.aribaud@free.fr you wrote:
Signed-off-by: Albert Aribaud albert.aribaud@free.fr
This patch:
- adds support in libata for the orion5x MVSATAHC controller;
- enables orion5x MVSTAHC port 1 on the edmini board;
- adds IDE and EXT2 commands to the edminiv2 command set.
What exactly do you mean by "libata"? Do we have something like this in U-Boot?
+/* ED Mini V2 uses SATA PORT1. Initialize this port and disable
- disable low power on it
- */
- /* mask for isolating IPM and DET fields in SControl register */
Incorrect multiline comment style.
-#if defined(__PPC__) || defined(CONFIG_PXA_PCMCIA) || defined(CONFIG_SH) +#if defined(__PPC__) || defined(CONFIG_PXA_PCMCIA) || defined(CONFIG_SH) \
- || defined(__ARM__)
Please do not add to this mess of tests, but introduce a single feature-specific #define instead.
-#if defined(__PPC__) || defined(CONFIG_PXA_PCMCIA) || defined(CONFIG_SH) +#if defined(__PPC__) || defined(CONFIG_PXA_PCMCIA) || defined(CONFIG_SH) \
- || defined(__ARM__)
Ditto here and everywhere else.
+/* Debugging features */
+/* #define the following if u-boot will boot from RAM */ +/* #undef it if u-boot will boot from FLASH */ +#undef CONFIG_SKIP_LOWLEVEL_INIT /* disable board lowlevel_init */
This seems to be an unrelated change (like someother, smaller ones). Please make sure to split your patches into independent parts.
Best regards,
Wolfgang Denk