Hi Wolfgang,
[...]
- if (path_len > MAX_TFTP_PATH_LEN) {
printf("Base path too long (%s%s)\n",bootfile_path ? bootfile_path : "",file_path);Indentation is one level only. Please fix globally.
Moving these printf args substantially to the right follows kernel CodingStyle guidelines and is more readable than a single level of indentation. Is this a deviation from the kernel CodingStyle that should go into the U-boot coding style wiki?
I think you misread the Coding Style here. What you are referring to is probably this:
Statements longer than 80 columns will be broken into sensible chunks. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. ^^^^^^^^^^^^^^^^
So this rule of "place substantially to the right" is given here for function >>headers<< only. I cannot find a place that makes such a comment for calling a function with a long argument list.
Actually the quoted text clearly applies to "descendants" of "statements longer than 80 columns" _and_ of "function headers". So I believe your reading is not correct.
But this is only a formal remark - I agree that the proposed change is to the worse ;)
Cheers Detlev