On 03-09-2018 at 19:59 +0530, Lokesh Vutla wrote:
On Sunday 02 September 2018 11:19 PM, Alexander Graf wrote:
Am 02.09.2018 um 18:04 schrieb Vagrant Cascadian vagrant@debian.org:
With LPAE available in all modern ARM cores, shouldn't phys_addr_t just be u64? And then we'd probably want to use that throughout the code, right?
Quite a few currently supported boards do not support LPAE, e.g. imx6.
What I'm trying to say is that we probably want to make phys_addr_t be u64 when CONFIG_LPAE is set.
That's right. Enabling PHYS_64BIT should be sufficient. Based on this phys_addr_t should be set to u32 or u64. arm already does that[1].
That will cause warnings from at least two sunxi drivers. I forgot which one the other was, but sunxi_mmc is one of them:
$ git grep -F -e '(u32 *)' drivers/mmc/sunxi_mmc.c drivers/mmc/sunxi_mmc.c: ccu_reg = (u32 *)ofnode_get_addr(args.node); drivers/mmc/sunxi_mmc.c: mmc_config_clk = (u32 *)ofnode_get_addr(args.node);
becase ofnode_get_addr() is declared like so:
include/dm/ofnode.h:phys_addr_t ofnode_get_addr(ofnode node);