Am 08.11.24 um 13:55 schrieb Yannic Moog:
Hi Wadim,
On Thu, 2024-11-07 at 09:52 +0100, Wadim Egorov wrote:
Hi Yannic,
Am 07.11.24 um 09:23 schrieb Yannic Moog:
The phyBOARD-Pollux expects 0x56000000 address to load optee.
You are already defining a default for IMX8M_OPTEE_LOAD_ADDR in the mach-imx Kconf. You can drop the patches touching the defconfigs.
I would like to keep these patches as the default value is "only" there to get a functioning build. To me it would seem there has been no thought put in to what the actual correct value would be if left as default. Does that make sense?
Yes, this makes sense. Up to you, it was just a hint.
Well, it will become de facto standard if you put a default value into the Kconfig regardless if there has been no thoughts on the best location for it. Other boards will probably just follow and reuse it anyway.
Yannic
Regards, Wadim
Signed-off-by: Yannic Moog y.moog@phytec.de
configs/phycore-imx8mp_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/phycore-imx8mp_defconfig b/configs/phycore-imx8mp_defconfig index 1240c7fcbd0..910109afd80 100644 --- a/configs/phycore-imx8mp_defconfig +++ b/configs/phycore-imx8mp_defconfig @@ -5,6 +5,7 @@ CONFIG_SYS_MALLOC_LEN=0x2000000 CONFIG_SPL_GPIO=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y +CONFIG_IMX8M_OPTEE_LOAD_ADDR=0x56000000 CONFIG_PHYTEC_SOM_DETECTION=y CONFIG_SF_DEFAULT_SPEED=80000000 CONFIG_ENV_SIZE=0x10000