15 Mar
2012
15 Mar
'12
3:30 a.m.
Hi Simon,
On Thu, Mar 15, 2012 at 1:16 PM, Simon Glass sjg@chromium.org wrote:
We want to unify the global_data structure. Most fields are common across architectures, but there are a fair number of SOC-specific additions. It isn't clear how best to deal with these, but for now we just use #ifdef.
Checkpatch warnings here might be unavoidable:
warning: include/asm-generic/global_data.h,43: do not add new typedefs warning: include/asm-generic/global_data.h,117: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt warning: include/asm-generic/global_data.h,121: storage class should be at the beginning of the declaration
IMHO global data does not need to be (and should not be) typedef'd
Regards,
Graeme