Hi Tom,
On Tue, Feb 28, 2012 at 10:12 AM, Simon Glass sjg@chromium.org wrote:
Hi,
On Mon, Feb 27, 2012 at 3:42 PM, Stephen Warren swarren@nvidia.com wrote:
On 02/27/2012 01:52 PM, Simon Glass wrote:
This series brings in the Linux kernel fdt file and provides a working USB driver for Tegra2 Seaboard.
Aside from the issues I just pointed out, this series looks fine. I didn't review most of the patches in detail though, just those related to the DT binding.
OK I have resent those three patches. Please can we fix up any other issues later and get this into U-Boot? Of course the .dts files in the kernel will change every now and then, but it is really easy to create a patch to bring U-Boot's copy up to date.
I also hit the C preprocessor problem with your binding - will need to be fixed at some point since others will hit it also. I'm tempted to move to sed, but if you don't get anywhere with your symbolic names in device tree then I won't.
Have just sent the new i2c patches. I had to do minor updates for 3 of the 9 patches, so just sent those (as version 4).
You should already have warmboot, which is next, but let me know if there are problems with it.
Regards, Simon
Regards, Simon
-- nvpublic