Re: [U-Boot] [PATCH 1/1] serial: ns16550: Read reg-io-type from device tree

On Thu, Aug 22, 2019 at 4:32 AM Bin Meng bmeng.cn@gmail.com wrote:

On Thu, Aug 22, 2019 at 12:40 AM Park, Aiden aiden.park@intel.com wrote:

...

Right, this is a just hack. As Bin said, we may need refactor whole codes. By the way, do we need to keep current design which selects I/O port or MMIO at compile time by defining CONFIG_SYS_NS16550_PORT_MAPPED or CONFIG_SYS_NS16550_MEM32?

I think we should drop these 2 config options, and refactor the whole 16550 driver, eg: porting the Linux 8250 driver to U-Boot.

Linux 8250 is quite old and actually full of quirks which makes it not the best example. Better not to take it and develop more clean solution in U-Boot.