On Mon, Jan 15, 2018 at 11:35:05AM +0900, Jaehoon Chung wrote:
Dear Tom,
Could you pull these patches to u-boot/master? Main topic is the support for HS200/UHS mode. If there are any problem, let me know. After applying to u-boot/master, will apply the other patches.
The following changes since commit f3dd87e0b98999a78e500e8c6d2b063ebadf535a:
Prepare v2018.01 (2018-01-08 20:25:29 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-mmc.git master
for you to fetch changes up to db359efd5907edbeaea2e3eb3504729f60208cd8:
mmc: fsl_esdhc: Fix eMMC 1.8v setting issue (2018-01-13 00:08:44 +0900)
Applied to u-boot/master, thanks!
But please note the following issues from checkpatch that need to be looked into and possibly followed up on: CHECK: Macro argument reuse 'mwt' - possible side-effects? #180: FILE: drivers/mmc/mmc.c:1245: +#define for_each_sd_mode_by_pref(caps, mwt) \ + for (mwt = sd_modes_by_pref;\ + mwt < sd_modes_by_pref + ARRAY_SIZE(sd_modes_by_pref);\ + mwt++) \ + if (caps & MMC_CAP(mwt->mode))
total: 0 errors, 0 warnings, 1 checks, 265 lines checked CHECK: Macro argument reuse 'mwt' - possible side-effects? #159: FILE: drivers/mmc/mmc.c:1382: +#define for_each_mmc_mode_by_pref(caps, mwt) \ + for (mwt = mmc_modes_by_pref;\ + mwt < mmc_modes_by_pref + ARRAY_SIZE(mmc_modes_by_pref);\ + mwt++) \ + if (caps & MMC_CAP(mwt->mode))
CHECK: Macro argument reuse 'ecbv' - possible side-effects? #177: FILE: drivers/mmc/mmc.c:1400: +#define for_each_supported_width(caps, ddr, ecbv) \ + for (ecbv = ext_csd_bus_width;\ + ecbv < ext_csd_bus_width + ARRAY_SIZE(ext_csd_bus_width);\ + ecbv++) \ + if ((ddr == ecbv->is_ddr) && (caps & ecbv->cap))
CHECK: Alignment should match open parenthesis #253: FILE: drivers/mmc/mmc.c:1437: + err = mmc_switch(mmc, EXT_CSD_CMD_SET_NORMAL, + EXT_CSD_BUS_WIDTH,
WARNING: 'occured' may be misspelled - perhaps 'occurred'? #292: FILE: drivers/mmc/mmc.c:1469: + /* if an error occured, revert to a safer bus mode */
total: 0 errors, 1 warnings, 3 checks, 320 lines checked WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: function ignore this. Modify mmc_set_ios() and the callers of mmc_set_ios() to
total: 0 errors, 1 warnings, 0 checks, 46 lines checked WARNING: ENOSYS means 'invalid syscall nr' and nothing else #30: FILE: drivers/mmc/mmc-uclass.c:100: + return -ENOSYS;
total: 0 errors, 1 warnings, 0 checks, 60 lines checked WARNING: 'capabilites' may be misspelled - perhaps 'capabilities'? #6: Add UHS modes to the list of supported modes, get the UHS capabilites of
total: 0 errors, 5 warnings, 0 checks, 381 lines checked WARNING: line over 80 characters #59: FILE: drivers/mmc/mmc.c:2217: + debug("Unable to do a full power cycle. Disabling the UHS modes for safety\n");
total: 0 errors, 1 warnings, 0 checks, 50 lines checked WARNING: 'optionnal' may be misspelled - perhaps 'optional'? #13: To make it clear that those are optionnal workarounds, a new Kconfig
total: 0 errors, 1 warnings, 0 checks, 102 lines checked WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #6: The SDcard initialization procedure does a few more things than it did earlier:
total: 0 errors, 1 warnings, 0 checks, 13 lines checked WARNING: please write a paragraph that describes the config symbol fully #50: FILE: common/spl/Kconfig:419: +config SPL_MMC_WRITE
WARNING: please write a paragraph that describes the config symbol fully #69: FILE: drivers/mmc/Kconfig:13: +config MMC_WRITE
total: 0 errors, 2 warnings, 0 checks, 82 lines checked CHECK: Unbalanced braces around else statement #85: FILE: drivers/mmc/mmc.c:2089: + else {
total: 0 errors, 0 warnings, 1 checks, 116 lines checked WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 403 lines checked WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644