On Thu, Nov 30, 2017 at 09:27:13AM -0700, Simon Glass wrote:
Hi Tom,
On 29 November 2017 at 20:35, Tom Rini trini@konsulko.com wrote:
On Mon, Nov 20, 2017 at 03:33:31PM -0700, Simon Glass wrote:
Add a command which exercises the logging system.
Signed-off-by: Simon Glass sjg@chromium.org Reviewed-by: Lukasz Majewski lukma@denx.de
NAK. With clang-3.8 we see this (and many more): test/log/log_test.c:35:16: warning: implicit conversion from enumeration type 'enum uclass_id' to different enumeration type 'enum log_category_t' [-Wenum-conversion] UCLASS_MMC, UCLASS_SPI, LOGC_NONE, LOGC_END ^~~~~~~~~~
For nearly all instances of UCLASS_MMC and UCLASS_SPI in the code.
That is unfortunate. I was really hoping to use the uclass as the logging class. I'll have to add a cast or something like that,
There were a bunch of other clang related warnings in this series too (I wasn't sure which patch, nor for certain it was this series until I dropped 'em all, after sending the email here). Can you please grab clang-3.8 (easy in Debian 9/Ubuntu 16.04 at least) and see what pops up over the whole series? Also, don't move up newer as, sigh, there's a bunch of other warnings showing up unrelated there and I haven't sat down and tried to figure any of those out. Thanks!