In message 1208030816.23686.13.camel@elrond.atmel.sweden you wrote:
Add support for the AT91RM9200EK Board.
I guess you are aware that the merge window is not open, i. e. you are submitting this only for discussion here...
The goal is to have the board included when the merge window reopens.
diff -urN u-boot.cmp/board/atmel/at91rm9200ek/at91rm9200ek.c u-boot/board/atmel/at91rm9200ek/at91rm9200ek.c --- u-boot.cmp/board/atmel/at91rm9200ek/at91rm9200ek.c 1970-01-01 01:00:00.000000000 +0100 +++ u-boot/board/atmel/at91rm9200ek/at91rm9200ek.c 2008-04-12 21:28:59.000000000 +0200 @@ -0,0 +1,142 @@ +/*
- (C) Copyright 2002
- Sysgo Real-Time Solutions, GmbH <www.elinos.com>
- Marius Groeger mgroeger@sysgo.de
A new file, and these are the only copyright holders? Really? Ditto for the other files.
Not a new file, a 3+ years old file.
There are coding style issues: trailing white space,
OK.
diff -urN u-boot.cmp/board/atmel/at91rm9200ek/flash.c u-boot/board/atmel/at91rm9200ek/flash.c --- u-boot.cmp/board/atmel/at91rm9200ek/flash.c 1970-01-01 01:00:00.000000000 +0100 +++ u-boot/board/atmel/at91rm9200ek/flash.c 2008-04-12 21:15:08.000000000 +0200 @@ -0,0 +1,509 @@ +/*
- (C) Copyright 2002
- Lineo, Inc. <www.lineo.com>
- Bernhard Kuhn bkuhn@lineo.com
I think this is CFI conformant flash, isn't it? So please use the CFI driver instead.
This code has been tested on the AT91RM9200EK board (not by me) and CFI code has not been tested on the AT91RM9200EK board.
So I see four possible choices. 1) Do not add AT91RM9200EK support in u-boot. 2) Add current *tested* support for AT91RM9200EK 3) Add AT91RM9200EK with CFI support without more than rudimentary testing 4) Wait until someone else tests CFI support on AT91RM9200EK and submits
---- Option 5) "Add AT91RM9200EK after me thorougly testing CFI support" is not going to happen due to time constraints and/or other priorities.
The flash driver already exists in the AT91RM9200DK board support package. This board is obsolete since 4 years or so. Most people using U-boot for AT91 does not use the main trunk. They use the Atmel specific version for which there exist no good method for non-Atmel people to submit patches.
I think the most practical approach to allow getting rid of the Atmel specific version is to include the legacy stuff (AT91RM9200 related) first. Then move the shared stuff to an board/atmel/common directory to make it easy to clean up for those interested later.
Best regards,
Best Regards Ulf Samuelsson