On Sun, Jun 28, 2020 at 06:20:52PM +0800, Kever Yang wrote:
pycrypto is needed for script to generate correct its.
Signed-off-by: Kever Yang kever.yang@rock-chips.com
.gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index f2e491c117..4841e7afbe 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -67,7 +67,7 @@ build all 64bit ARM platforms: script: - virtualenv -p /usr/bin/python3 /tmp/venv - . /tmp/venv/bin/activate
- pip install pyelftools
- pip install pyelftools pycrypto
- ret=0; ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?; if [[ $ret -ne 0 ]]; then
@@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites: export USER=gitlab; virtualenv -p /usr/bin/python3 /tmp/venv; . /tmp/venv/bin/activate;
pip install pyelftools pytest;
pip install pyelftools pytest pycrypto; export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl; export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt"; export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";
We need to update all of the CI config files to install the needed modules. I also assume we haven't pushed changes in yet that require pycrypto, so which tool is going to need it? I want to make sure we document it and perhaps we need to start thinking about a requirement.txt for our python tools if it's binman that needs it (as that's what also needs pyelftools). Thanks!