Dear micro1183,
In message 52E2615C.1000207@gmail.com you wrote:
This patch adds support for the silica pengwyn board with AM335x SoC
Your patch is line-wrapped and does not apply. Please fix your mailer configuration.
+/*
- board.c
- Copyright (C) 2013 Lothar Felten lothar.felten@gmail.com
- This program is free software; you can redistribute it and/or
- modify it under the terms of the GNU General Public License as
- published by the Free Software Foundation version 2.
Please use a SPDX license tag instead. And please notice that new code should have GPL-2.0+; GPL-2.0 is not sufficient.
Please fix globally.
+#include <common.h> +#include <errno.h> +#include <spl.h> +#include <asm/arch/cpu.h> +#include <asm/arch/hardware.h> +#include <asm/arch/omap.h> +#include <asm/arch/ddr_defs.h> +#include <asm/arch/clock.h> +#include <asm/arch/gpio.h> +#include <asm/arch/mmc_host_def.h> +#include <asm/arch/sys_proto.h> +#include <asm/io.h> +#include <asm/emif.h> +#include <asm/gpio.h> +#include <i2c.h> +#include <miiphy.h> +#include <cpsw.h> +#include <power/tps65217.h> +#include "board.h"
Do you really need all these headers?
+#define MACH_TYPE_PENGWYN 1234
MACH-ID 1234 is registered for the gene1270 bord. Please do not hijack other board's IDs! Register your own instead, please.
+/* Always 128 KiB env size */ +#define CONFIG_ENV_SIZE (128 << 10)
This makes no sense. You will never need that much, and such a huge size just slows down booting etc.
+/* NS16550 Configuration */ +#define CONFIG_SYS_NS16550_COM1 0x44e09000 /* Base EVM has UART0 */ +#define CONFIG_SYS_NS16550_COM2 0x48022000 /* UART1 */ +#define CONFIG_SYS_NS16550_COM3 0x48024000 /* UART2 */ +#define CONFIG_SYS_NS16550_COM4 0x481a6000 /* UART3 */ +#define CONFIG_SYS_NS16550_COM5 0x481a8000 /* UART4 */ +#define CONFIG_SYS_NS16550_COM6 0x481aa000 /* UART5 */
Do you really need all of these?
+#define CONFIG_USBNET_HOST_ADDR "de:ad:be:af:00:00"
Is this a good idea?
+/* USB TI's IDs */ +#define CONFIG_G_DNL_VENDOR_NUM 0x0403 +#define CONFIG_G_DNL_PRODUCT_NUM 0xBD00 +#define CONFIG_G_DNL_MANUFACTURER "Texas Instruments"
Is this really a TI board?
Best regards,
Wolfgang Denk