Wolfgang Denk wrote:
Dear Michal Simek,
In message 1292955178-13018-1-git-send-email-monstr@monstr.eu you wrote:
Clear coding style issues.
Signed-off-by: Michal Simek monstr@monstr.eu
lib/asm-offsets.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c index 2209561..f1af7e2 100644 --- a/lib/asm-offsets.c +++ b/lib/asm-offsets.c @@ -19,11 +19,11 @@
#include <linux/kbuild.h>
-int main(void) +int main (void) { /* Round up to make sure size gives nice stack alignment */
- DEFINE(GENERATED_GBL_DATA_SIZE,
(sizeof(struct global_data)+15) & ~15);
- DEFINE (GENERATED_GBL_DATA_SIZE,
(sizeof (struct global_data) + 15) & ~15);These changes are to the worse. All. Why do you think this would be better?
It is what intend suggest to do. intend -npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1 -pcs
I am OK to remove space between macro name and argument as you suggested in your other email.
- DEFINE (GENERATED_GBL_DATA_SIZE,
(sizeof (struct global_data) + 15) & ~15);
^ ^ ^ ^
I believe that marked space are OK, or not?
Thanks, Michal