-----Original Message----- From: Priyanka Jain (OSS) priyanka.jain@oss.nxp.com Sent: Friday, April 24, 2020 11:18 AM To: Ioana Ciornei ioana.ciornei@nxp.com; u-boot@lists.denx.de Cc: Alexandru Marginean alexandru.marginean@nxp.com; Madalin Bucur madalin.bucur@nxp.com; Florin Laurentiu Chiculita florinlaurentiu.chiculita@nxp.com; Razvan Ionut Cirjan razvanionut.cirjan@nxp.com Subject: RE: [PATCH 1/6] arm: dts: lx2160a: add any missing dpmac nodes
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Ioana Ciornei Sent: Wednesday, April 22, 2020 10:39 PM To: Priyanka Jain priyanka.jain@nxp.com; u-boot@lists.denx.de Cc: Alexandru Marginean alexandru.marginean@nxp.com; Madalin Bucur madalin.bucur@nxp.com; Florin Laurentiu Chiculita florinlaurentiu.chiculita@nxp.com; Razvan Ionut Cirjan razvanionut.cirjan@nxp.com; Ioana Ciornei ioana.ciornei@nxp.com Subject: [PATCH 1/6] arm: dts: lx2160a: add any missing dpmac nodes
Instead of "any missing" , please provide details on what you are adding. May be something like "Add dpmac1-2, dpmac5-16 nodes"
Add the remaining DPMAC nodes in the LX2160A base dtsi.
Similar comment here. Provide details of remaining.
These will be later used on the LX2160AQDS specific DTS.
Signed-off-by: Ioana Ciornei ioana.ciornei@nxp.com
arch/arm/dts/fsl-lx2160a.dtsi | 86 ++++++++++++++++++++++++++++++++++- 1 file changed, 85 insertions(+), 1 deletion(-)
diff --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-
lx2160a.dtsi
index 17ecdc569b37..9499fb9a3779 100644 --- a/arch/arm/dts/fsl-lx2160a.dtsi +++ b/arch/arm/dts/fsl-lx2160a.dtsi @@ -2,7 +2,7 @@ /*
- NXP lx2160a SOC common device tree source
- Copyright 2018 NXP
- Copyright 2018, 2020 NXP
Copyright 2018-2020 NXP
Were changes made in 2019 too? Otherwise, "2018,2020" is correct
*/
<snip> Priyanka