Hi Giuseppe,
On 15/11/2013 17:42, Giuseppe Pagano wrote:
Move setup_sata function definition from platform file nitrogen6x.c to arch/arm/imx-common/sata.c to avoid code duplication.
Signed-off-by: Giuseppe Pagano giuseppe.pagano@seco.com CC: Stefano Babic sbabic@denx.de CC: Fabio Estevam fabio.estevam@freescale.com CC: Eric Nelson eric.nelson@boundarydevices.com
Changes in v2:
- Split previous patch between nitrogen6x udoo code changes.
arch/arm/imx-common/Makefile | 1 + arch/arm/imx-common/sata.c | 33 ++++++++++++++++++++++++++++++++ arch/arm/include/asm/imx-common/sata.h | 17 ++++++++++++++++ board/boundary/nitrogen6x/nitrogen6x.c | 27 +------------------------- 4 files changed, 52 insertions(+), 26 deletions(-) create mode 100644 arch/arm/imx-common/sata.c create mode 100644 arch/arm/include/asm/imx-common/sata.h
diff --git a/arch/arm/imx-common/Makefile b/arch/arm/imx-common/Makefile index 727a052..6f85c42 100644 --- a/arch/arm/imx-common/Makefile +++ b/arch/arm/imx-common/Makefile @@ -17,6 +17,7 @@ endif ifeq ($(SOC),$(filter $(SOC),mx5 mx6)) COBJS-y += timer.o cpu.o speed.o COBJS-$(CONFIG_I2C_MXC) += i2c-mxv7.o +COBJS-$(CONFIG_CMD_SATA) += sata.o
By testing this breaks mx5 boards: Boards with errors: 3 ( m53evk ima3-mx53 mx53loco )
The reason is that mx5 does not have and does not need a setup_sata, and the code in sata.c (all registers definitions) are mx6 specific.
I suggest the file is compiled only for iMX6 (now it is for both mx5 and mx6) as result of filter.
Can you send a V3 of the two sata patches ? You do not need to resend the whole patchset.
Best regards, Stefano Babic