On 01/25/2016 01:36 PM, Lubomir Rintel wrote:
It seems like the P5 header was not present on "Model B" any board prior to Revision 2.0, there's no need for a separate device tree.
Also, it looks like "rev2" is incorrectly used to only cover the 512MiB memory models; there also were 256MiB 2.0 boards.
I don't have all of the boards to check this, I'm following this table: http://elinux.org/RPi_HardwareHistory#Board_Revision_History
Yes, I believe this makes sense, and is consistent with the URLs listed as data sources just a little above the model table.
I tested this patch on board rev 0x2 (B, no P5/rev1, 256M), 0x8 (A, 256M), 0xf (B, P5/rev2, 512M).
Acked-by: Stephen Warren swarren@wwwdotorg.org
It would be really nice if you could get someone at the Pi Foundation to validate the complete updated tables (at least, the revision number to model name mapping) in this file after this patch. I CC'd Gordon and Dom to see if one of them could do that, or track someone down who can. Gordon, Dom, you can find the file content at:
https://github.com/swarren/u-boot/blob/rpi_dev/board/raspberrypi/rpi/rpi.c#L...
P.S. Lubomir, I used my personal email swarren@wwwdotorg.org for RPi work, not my work email swarren@nvidia.com.
Thanks for working on cleaning this up.