Hi,
On 02/07/2015 07:02 PM, Simon Glass wrote:
Hi Hans,
On 7 February 2015 at 10:59, Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 02/07/2015 06:47 PM, Simon Glass wrote:
Make sunxi's FEL code fit with the normal U-Boot boot sequence instead of creating its own. There are some #ifdefs required in start.S. Future work will hopefully remove these.
About the #ifdefs, I would really like to see us move to having 1 unified loader for sunxi, which means getting rid of them. Even though we do use a label to return from save_boot_params, save_boot_params could still use r0 to return stuff, like you did in your previous patch-set, or we could add a global variable to start.S which lives in .data and gets initialized with 0, and save_boot_params could optionally save some skip flags there.
Note this dropping of #ifdefs can wait till after v2015.04, for now this patch-set should get fel mode working as before which is the goal for v2015.04.
OK. It's just as easy for me to do this now, but Albert was not keen on doing this at run-time.
So if you can remove the #ifdefs by calling back into the BROM that would probably be better.
Calling back into the BROm, rather then returning into it means that usb needs to get re-initialized and the usb-host will see a usb disconnect / reconnect, which is not really pretty, so I would like to avoid that, and instead use something like your proposed runtime checking with flags
For now I think Albert prefers the #ifdefs.
#ifdefs are fine for v2015.04, but for v2015.07 I really believe we need something runtime so that we can move to one unified loader for sunxi. Albert can you give us some guidance on how we can best implement runtime checks like the ones which Simon did with flags stored in r0 in his initial patch-set ?
Regards,
Hans