Dear Wolfgang Denk,
[...]
Maybe we can sae one call to objdump by storing the intermediate result?
I removed the other call in subsequent patch anyway, so this is fine now.
cd $(LNDIR) && $(LD) $(LDFLAGS) $(LDFLAGS_$(@F)) \$$UNDEF_SYM $$UNDEF_LST $(__OBJS) \Hm.... we use UNDEF_SYM and UNDEF_LST in exactly the same way? The why cannot we do this all in a single run, like:
UNDEF_SYM=`$(OBJDUMP) -x $(LIBBOARD) $(LIBS) | \ sed -n -e 's/.*($(SYM_PREFIX)__u_boot_cmd_.*)/-u\1/p' \ -e 's/.*($(SYM_PREFIX)_u_boot_list_.*)/-u\1/p' | sort | uniq`;
\
cd $(LNDIR) && $(LD) $(LDFLAGS) $(LDFLAGS_$(@F)) $$UNDEF_SYM $(__OBJS) \ ...
?
See above, otherwise I do agree.
@rm -f $(obj)board/cray/L1/{bootscript.c,bootscript.image} \
$(obj)board/matrix_vision/*/bootscript.img \ $(obj)board/voiceblue/eeprom \
$(obj)u-boot.lds \
$(obj)u-boot.lds,include/u-boot.lst \s/,/ / here!!!
Argh, it's been merged already, right? Fixup patch on the way.
- @rm -f
$(obj)nand_spl/{u-boot.{lds,lst},u-boot-nand_spl.lds,u-boot-spl,u-boot-s pl.map,System.map} + @rm -f $(obj)spl/{u-boot-spl,u-boot-spl.bin,u-boot-spl.{lds,lst},u-boot-spl.map }
Line length?
True.
Best regards,
Wolfgang Denk
Best regards, Marek Vasut