On Wed, 2024-01-24 at 14:30 +0100, Mathieu Othacehe wrote:
Hello Yannic,
As a heads-up: you need to rebase as am62 (doc) got applied by Tom.
Noted.
Is the trusted-firmware-a upstream version working? If so, please use that instead.
It is but only on the master branch, so it might be better to stick to the nxp-imx repository until a lts release is created.
Ok, sounds reasonable.
+#include <config_distro_bootcmd.h>
I don't see a specific reason to have this include separate?! Group it with the others, please.
Many other include files place it here, right after the BOOT_TARGET_DEVICES macro, so I guess there must be a reason, even though I am unsure why :).
See doc/develop/distro.rst for information. The reason to have this separate is to have this wrapped in ifdefs. Since you have this unconditionally, you may move this include as far as I can tell.
Thanks,
Mathieu