On 09/12/2011 01:05 PM, Sughosh Ganu wrote:
hi Stefano,
On Fri Sep 09, 2011 at 11:04:14AM +0200, Stefano Babic wrote:
On 09/09/2011 09:36 AM, Wolfgang Denk wrote:
<snip>
Hi Sughosh,
Sorry for not having caught this earlier. I ran git bisect on this, and the commit "401bb30b6d replace CONFIG_PRELOADER with CONFIG_SPL_BUILD" seems to be causing the build break.
The issue seems to be that the code in board/davinci/common/misc.c gets conditionally compiled based on definition of CONFIG_PRELOADER symbol, which was removed in this commit, and replaced by CONFIG_SPL_BUILD.
Yes, right.
I think we should correspondingly change this check in misc.c, so that it would not be required to compile in memsize.c. Let me know, and i will test this change and send out a patch. Thanks.
Agree. This is the right solution.
Best regards, Stefano Babic