Re: [U-Boot] [PATCH v5 1/1] imx: Get fec mac address from fuse

18 Nov 2010


      On 11/18/2010 11:33 AM, Jason Liu wrote:
...
...
...

for (i = 0; i < 6; i++)


        mac[6-1-i] = readl(&fuse->mac_addr[i]);


                ^
                |--- missing spaces

do you mean it need change to mac[6 - 1 - i] ?
Yes, this is a coding style issue.
...
I think that the original mx27 code should be wrong.
I come with the same conclusion.
Best regards,
Stefano Babic
-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=====================================================================