Re: [PATCH 1/1] efi_loader: fix efi_dp_from_eth

On Sat, 21 Oct 2023 at 23:20, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:

When compiling the sandbox with CONFIG_LTO=n, CONFIG_NET=n an error is reported:

/usr/bin/ld: lib/efi_loader/efi_device_path.o:
in function `efi_dp_from_eth':
lib/efi_loader/efi_device_path.c:985:(.text+0xcf4):
undefined reference to `eth_get_dev'

Add a missing configuration check.

As the function is exported __maybe_unused can be removed.

Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com

lib/efi_loader/efi_device_path.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass sjg@chromium.org