Hi Jens,
On 19 July 2018 at 09:49, Jens Wiklander jens.wiklander@linaro.org wrote:
On Thu, Jul 19, 2018 at 3:32 AM, Simon Glass sjg@chromium.org wrote:
Hi Jens,
On 17 July 2018 at 09:42, Jens Wiklander jens.wiklander@linaro.org wrote:
On Sun, Jul 15, 2018 at 11:20:39PM -0600, Simon Glass wrote:
On 13 July 2018 at 04:12, Jens Wiklander jens.wiklander@linaro.org wrote:
Prior to this patch is fdtdec_setup_memory_banksize() incorrectly ignoring the "status" field. This patch fixes that by testing the status with fdtdec_get_is_enabled() before using a memory node.
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org
lib/fdtdec.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
But can you convert this to livetree at the same time? E.g. use ofnode functions.
I can try, but the ofnode concept is new to me.
This patch is based on the fdt_node_offset_by_prop_value() function. I can't find any such ofnode function or any other suitable helper function. Perhaps I'm missing something, or should I add an ofnode_by_prop_value() function (similar to ofnode_by_compatible())?
Please advice.
advise :-)
Yes, you could add that function. Sorry it doesn't already exists.
I'll give it a shot after my vacation. In the meantime can we take this patch or would you rather wait for the livetree version?
We can take it.
Regards, Simon