
Dear Scott,
In message 4A0333FC.6090900@freescale.com you wrote:
Wolfgang Denk wrote:
Finally, and this is what I really compalin about, is that there is no big structure which includes all the blocks that make up the CPU into one big structure (as it's done for example for PowerPC systems in the include/asm-ppc/*immap* files) - you still use code like
Those immap structs are a huge pain to maintain (or to verify the correctness of), loaded with ifdeffery and magic numbers describing reserved spans. We should not be emulating them.
Well, #define'ing long lists of register offsets is not easier to maintain or verify, and you don't have any typechecking by the compiler.
We used to have them in Linux, and got rid of them.
Hm... Seems I have missed this change... What's things like
struct qe_immap __iomem *qe_immr or cpm2_map_t __iomem *cpm2_immr or immap_t __iomem *mpc8xx_immr
then? Or what replaced the "immr" structs?
Best regards,
Wolfgang Denk