27 Jun
2012
27 Jun
'12
7:32 p.m.
Hello Stephen,
On 6/27/2012 7:09 AM, Stephen Warren wrote:
On 06/24/2012 11:21 AM, Vikram Narayanan wrote:
First off, it's great to see some patches for the chip. Thanks. Sorry for being so nit-picky below; it's a tendency of mine...
Thanks for the detailed review. I'd make a v2 for this. And I might probably include you in the signed-off-by line. Hope you don't mind that.
Do you have a hosted repo somewhere for this rpi_b stuff? If so, please post it here or we shall have one, which has all the patches queued in for the mainline. What do you say? Share your opinions about this.
BTW, I don't think this patch compiles; gpio_set_value() references variable "pin", which doesn't exist.
Sorry about that, Late night submission!
Thanks, Vikram