On Tuesday 06 March 2007 23:45, Ulf Samuelsson wrote:
When adding "cpu/freescale/" I see no clear line what should go in there and what not. Whould we then move all the cpu/mpc???/ directories into cpu/freescale/ ? And then probably create (for consistency) a "cpu/amcc/" directory and mode cpu/ppc4xx into that one? What do we get in addition to another directory level? IMO that would not improve anything, and you still don't see where shared code is located.
I think you can still keep the cpu/ppc4xx directory but if you find that cpu/ppcYYY has shared code with the cpu/ppc4xx and you would like to have a common driver, then you put it in "cpu/amcc/ppc.
For freescale you would put shared code in cpu/freescale/imx and cpu/freescale/ppc and maybe cpu/freescale/coldfire
I still think that this code we are talking about here, is most likely some driver code for some ethernet controller, or a I2C controller etc. I would like to "collect" this sort of driver code, even if it's SoC driver code, under the "drivers" directory. This is already done for some drivers but it's not done consistently. We already have:
drivers/qe/* drivers/netarm_eth.* drivers/omap1510_i2c.* ...
Why not try to match this a little more to the Linux directory structure:
drivers/net/netarm_eth.* drivers/net/qe/* drivers/i2c/omap1510_i2c.* ...
From my understanding the drivers mentioned above will fit in here much better than in some cpu directories. Just my 0.02$.
BTW: I know it's always a problem to "move" code in a version control system because of the revision history.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany =====================================================================