On 06.09.2016 20:53, Stephen Warren wrote:
On 09/05/2016 07:29 AM, Julian Scheel wrote:
Add support for platforms based on the Meerkat COM module. Includes support for the minimal reference platform called Kein Baseboard, which in fact is sufficient to run most existing Meerkat carriers.
diff --git a/board/avionic-design/common/meerkat.c b/board/avionic-design/common/meerkat.c
+int tegra_pcie_board_init(void)
- err = as3722_init(&pmic, 4, 0x40);
Thinking about this more: Why I2C bus 4 not 0? All other boards set up the PMIC I2C bus to be I2C bus 0 in U-Boot's numbering scheme. I'm not sure we should deviate from that since it will provide users (running the i2c command at the U-Boot shell) with an inconsistent experience.
Please see the discussion from earlier this year, when I initially sent this patches: http://lists.denx.de/pipermail/u-boot/2016-February/246952.html
Still if you're too unhappy about it now we would change it, but if not we'd rather keep it that way. Having a user being confused because of different mapping in our l4t kernel and uboot seems to be more likely than a user being confused because of different mappings on different boards to me.
Also, 0x40 is the I2C address that's used before this series, so I don't think there's a need to pass the value in as a parameter since all boards use the same value. In fact, that value is part of the AS3722 HW itself, so I'm not sure that it could actually vary, unless there are address strapping pins on the chip. Even if so, it seems a bit unlikely someone would actually use them to select a non-default address, at least in situations likely to be encountered on any Tegra board.
I'd be ok with dropping that. I think Alban simply added it because he was at it and it was an obvious parameter which might need to be changed sometime.
-Julian