On Thu, Jun 14, 2012 at 6:36 AM, Jaehoon Chung jh80.chung@samsung.com wrote:
Hi Rajeshwari,
This patch has too many dependence with other patches. (Pinmux and PeripID, patches for MSHCI setting). And as i mentioned, designWare controller isn't exynos specific.
I think good that separate two files. (dw_mmc.c and exynos_dw_mmc.c) Like this...dw_mmc.c is generic code and exynos_dw_mmc.c is samsung specific code.. If you want, I will send to you patch that related with them. (based-on your patch)
And Added some comment
[...]
Everyone, please remove any unnecessary context when you reply to patches (or any email). When I attempt to read your review comments in patchworks, I have to scroll for pages, carefully, to find them. Just quote enough of the patch so everyone can understand what code your comments are about.
+static int dw_mci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,
struct mmc_data *data)+{
struct dw_mci_host *host = mmc->priv;mmc->priv's type is void type. I think good that use (struct dw_mci_host *)mmc->priv;
Casting a void * is unnecessary, and pollutes the code with redundant information. The purpose of requiring explicit casts is to make sure one doesn't make an unintended implicit cast between two different types. But a void * is intentionally typeless, and the explicit cast provides no extra checking.
Andy